Differential D1134

Modernize compact block code
ClosedPublic
Actions

Authored by deadalnix on Feb 25 2018, 13:57.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Maniphest Tasks

T297: Allow for 32 Megabyte blocks

Commits

rSTAGINGd3922e32044c: Modernize compact block code
rABCd3922e32044c: Modernize compact block code

Summary

indexes -> indices
Use C++11 loops when possible
Add braces
Use C++ constructors instead C style casts.

Test Plan

make check
./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmpblknits

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1929
Build 2016: Bitcoin ABC Buildbot (legacy)
Build 2015: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 25 2018, 13:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 25 2018, 13:57

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B1929: Diff 2979.Feb 25 2018, 14:17

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

jasonbcox accepted this revision.Feb 25 2018, 21:06

This revision is now accepted and ready to land.Feb 25 2018, 21:06

Closed by commit rABCd3922e32044c: Modernize compact block code (authored by deadalnix). · Explain WhyFeb 25 2018, 21:07

This revision was automatically updated to reflect the committed changes.

schancel added a task: T297: Allow for 32 Megabyte blocks.Mar 15 2018, 14:52

Revision Contents
Changeset List

Path

Size

src/

blockencodings.h

65 lines

blockencodings.cpp

95 lines

net_processing.cpp

12 lines

test/

blockencodings_tests.cpp

20 lines

Diff 2979

View Options

src/blockencodings.h

View Options

src/blockencodings.cpp

View Options

src/net_processing.cpp

View Options

src/test/blockencodings_tests.cpp

Modernize compact block codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2979

src/blockencodings.h

src/blockencodings.cpp

src/net_processing.cpp

src/test/blockencodings_tests.cpp

Modernize compact block code
ClosedPublic
Actions

Revision Contents
Changeset List