[Cashtab] Remove separate block explorers for token txs
ClosedPublic
Actions

Authored by kieran709 on May 5 2022, 18:36.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC58b8a049ddc7: [Cashtab] Remove separate block explorers for token txs

Summary

In Ticker.js, removed currency.tokenExplorerUrl, and replaced value of currency.blockExplorerUrl to explorer.be.cash. In useBCH.js and useBCH.test.js, replaced each instance of currency.tokenExplorerUrl with currency.blockExplorerUrl. Related to task T2215.

Test Plan

cd web/cashtab && npm start

From the terminal:
Run grep -r 'tokenExplorerUrl' src/ - observe that nothing is returned.

From the wallet tab:
Click on an XEC transaction, ensure that the link leads to explorer.be.cash.
Click on an eToken transaction, ensure that the linke leads to explorer.be.cash.
Send eToken, click on transaction as above
Receive eToken, click on transaction as above

Diff Detail

Repository

rABC Bitcoin ABC

Branch

replace-remove-block-explorer

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18964
Build 37692: Build Diff	cashtab-tests
Build 37691: arc lint + arc unit

Event Timeline

kieran709 created this revision.May 5 2022, 18:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2022, 18:36

kieran709 requested review of this revision.May 5 2022, 18:36

Harbormaster completed remote builds in B18964: Diff 33421.May 5 2022, 18:39

Running grep -r 'tokenExplorerUrl' src/

gives this output:

src/hooks/useBCH.js:            link = `${currency.tokenExplorerUrl}/tx/${txidStr}`;
src/components/Home/Tx.js:                                    href={`${currency.tokenExplorerUrl}/tx/${data.txid}`}

should be no references left in app. this should be part of the test plan.

This revision now requires changes to proceed.May 5 2022, 22:02

Responding to review feedback

kieran709 edited the test plan for this revision. (Show Details)May 6 2022, 06:01

Harbormaster completed remote builds in B18970: Diff 33430.May 6 2022, 06:03