Page MenuHomePhabricator

[Cashtab] Remove separate block explorers for token txs
ClosedPublic

Authored by kieran709 on May 5 2022, 18:36.

Details

Summary

In Ticker.js, removed currency.tokenExplorerUrl, and replaced value of currency.blockExplorerUrl to explorer.be.cash. In useBCH.js and useBCH.test.js, replaced each instance of currency.tokenExplorerUrl with currency.blockExplorerUrl. Related to task T2215.

Test Plan

cd web/cashtab && npm start

From the terminal:
Run grep -r 'tokenExplorerUrl' src/ - observe that nothing is returned.

From the wallet tab:
Click on an XEC transaction, ensure that the link leads to explorer.be.cash.
Click on an eToken transaction, ensure that the linke leads to explorer.be.cash.
Send eToken, click on transaction as above
Receive eToken, click on transaction as above

Diff Detail

Repository
rABC Bitcoin ABC
Branch
replace-remove-block-explorer
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18992
Build 37745: Build Diffcashtab-tests
Build 37744: arc lint + arc unit

Event Timeline

bytesofman requested changes to this revision.May 5 2022, 22:02

Running grep -r 'tokenExplorerUrl' src/

gives this output:

src/hooks/useBCH.js:            link = `${currency.tokenExplorerUrl}/tx/${txidStr}`;
src/components/Home/Tx.js:                                    href={`${currency.tokenExplorerUrl}/tx/${data.txid}`}

should be no references left in app. this should be part of the test plan.

This revision now requires changes to proceed.May 5 2022, 22:02

Responding to review feedback

  1. The only block explorer should be explorer.be.cash
  2. Amend test plan to include running grep -r 'tokenExplorerUrl' src/ and seeing no output
web/cashtab/src/components/Common/Ticker.js
16 ↗(On Diff #33430)

the remaining explorer should be https://explorer.be.cash

This revision now requires changes to proceed.May 10 2022, 14:18

Responding to review feedback, test plan changed to include grep -r 'tokenExplorerUrl' src/

This revision is now accepted and ready to land.May 16 2022, 15:47