Page MenuHomePhabricator
Differential D11496

move getAvalancheVoteForBlock to PeerManagerImpl
ClosedPublic
Actions

Authored by PiRK on May 19 2022, 09:43.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCe0cf6c0afd32: move getAvalancheVoteForBlock to PeerManagerImpl
Summary

It is only called in another PeerManagerImpl method, and it needs access to g_chainman which is about to be replaced by m_chainman throughout net_processing.cpp

Also capitalize the first word, to follow the convention used for all other methods.

Depends on D11495

Test Plan

With clang and debug
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 19 2022, 09:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 19 2022, 09:43
PiRK requested review of this revision.May 19 2022, 09:43
PiRK updated this revision to Diff 33610.

deduplicate doxygen comment

PiRK edited the summary of this revision. (Show Details)May 19 2022, 09:45
Harbormaster completed remote builds in B19106: Diff 33609.May 19 2022, 09:55
teamcity added a comment.May 19 2022, 09:55
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

wallet_abandonconflict.py                              | ✓ Passed  | 8 s
wallet_address_types.py                                | ✓ Passed  | 12 s
wallet_address_types.py --descriptors                  | ✓ Passed  | 8 s
wallet_avoidreuse.py                                   | ✓ Passed  | 4 s
wallet_avoidreuse.py --descriptors                     | ✓ Passed  | 5 s
wallet_backup.py                                       | ✓ Passed  | 34 s
wallet_balance.py                                      | ✓ Passed  | 13 s
wallet_balance.py --descriptors                        | ✓ Passed  | 15 s
wallet_basic.py                                        | ✓ Passed  | 23 s
wallet_coinbase_category.py                            | ✓ Passed  | 1 s
wallet_create_tx.py                                    | ✓ Passed  | 5 s
wallet_createwallet.py                                 | ✓ Passed  | 2 s
wallet_createwallet.py --descriptors                   | ✓ Passed  | 2 s
wallet_createwallet.py --usecli                        | ✓ Passed  | 3 s
wallet_descriptor.py                                   | ✓ Passed  | 6 s
wallet_disable.py                                      | ✓ Passed  | 0 s
wallet_dump.py                                         | ✓ Passed  | 4 s
wallet_encryption.py                                   | ✓ Passed  | 5 s
wallet_encryption.py --descriptors                     | ✓ Passed  | 5 s
wallet_hd.py                                           | ✓ Passed  | 6 s
wallet_hd.py --descriptors                             | ✓ Passed  | 6 s
wallet_import_rescan.py                                | ✓ Passed  | 5 s
wallet_import_with_label.py                            | ✓ Passed  | 1 s
wallet_importdescriptors.py                            | ✓ Passed  | 7 s
wallet_importmulti.py                                  | ✓ Passed  | 3 s
wallet_importprunedfunds.py                            | ✓ Passed  | 2 s
wallet_importprunedfunds.py --descriptors              | ✓ Passed  | 2 s
wallet_keypool.py                                      | ✓ Passed  | 3 s
wallet_keypool_topup.py                                | ✓ Passed  | 3 s
wallet_keypool_topup.py --descriptors                  | ✓ Passed  | 3 s
wallet_labels.py                                       | ✓ Passed  | 2 s
wallet_labels.py --descriptors                         | ✓ Passed  | 2 s
wallet_listreceivedby.py                               | ✓ Passed  | 28 s
wallet_listsinceblock.py                               | ✓ Passed  | 4 s
wallet_listsinceblock.py --descriptors                 | ✓ Passed  | 8 s
wallet_listtransactions.py                             | ✓ Passed  | 4 s
wallet_listtransactions.py --descriptors               | ✓ Passed  | 3 s
wallet_multiwallet.py                                  | ✓ Passed  | 40 s
wallet_multiwallet.py --usecli                         | ✓ Passed  | 11 s
wallet_reorgsrestore.py                                | ✓ Passed  | 3 s
wallet_resendwallettransactions.py                     | ✓ Passed  | 2 s
wallet_send.py                                         | ✓ Passed  | 7 s
wallet_startup.py                                      | ✓ Passed  | 2 s
wallet_txn_clone.py                                    | ✓ Passed  | 1 s
wallet_txn_clone.py --mineblock                        | ✓ Passed  | 3 s
wallet_txn_doublespend.py                              | ✓ Passed  | 1 s
wallet_txn_doublespend.py --mineblock                  | ✓ Passed  | 4 s
wallet_watchonly.py                                    | ✓ Passed  | 1 s
wallet_watchonly.py --usecli                           | ✓ Passed  | 1 s

ALL                                                    | ✓ Passed  | 1250 s (accumulated) 
Runtime: 251 s

----------------------------------------------------------------------
Ran 10 tests in 0.107s

OK

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
Harbormaster completed remote builds in B19107: Diff 33610.May 19 2022, 10:01
deadalnix requested changes to this revision.May 19 2022, 17:43
deadalnix added a subscriber: deadalnix.

It doesn't looks like it is using any state of the object, so why should this be a member method of that object? That doesn't make sense.

This revision now requires changes to proceed.May 19 2022, 17:43
deadalnix accepted this revision.May 19 2022, 17:44

I see, it is about to use a member. LGTM.

This revision is now accepted and ready to land.May 19 2022, 17:44
Closed by commit rABCe0cf6c0afd32: move getAvalancheVoteForBlock to PeerManagerImpl (authored by PiRK). · Explain WhyMay 19 2022, 18:52
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe0cf6c0afd32: move getAvalancheVoteForBlock to PeerManagerImpl.

Revision Contents
Changeset List

PathSize
src/
20 lines

Diff 33633

View Options

src/net_processing.cpp

Loading...