Paths

Table of Contentst

Differential D11744

make FindBlockToFinalize a CChainState member
ClosedPublic
Actions

Authored by PiRK on Jul 13 2022, 16:21.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC9d99cccc3809: make FindBlockToFinalize a CChainState member

Summary

The function needs the chainstate, and previously relied on ::ChainstateActive()

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

finalisation_chainstate

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19631
Build 38981: Build Diff	build-clang-tidy · lint-circular-dependencies · build-without-wallet · build-debug · build-diff · build-clang
Build 38980: arc lint + arc unit

Event Timeline

PiRK created this revision.Jul 13 2022, 16:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 13 2022, 16:21

PiRK requested review of this revision.Jul 13 2022, 16:21

Harbormaster completed remote builds in B19631: Diff 34362.Jul 13 2022, 16:37

PiRK mentioned this in D11748: use m_chain in CChainState::UpdateFlagsForBlock and CChainState::FinalizeBlock.Jul 14 2022, 08:02

PiRK mentioned this in rABCb562de8831b1: use m_chain in CChainState::UpdateFlagsForBlock and CChainState::FinalizeBlock.Jul 15 2022, 07:43

PiRK added a child revision: D11752: qt/test: Reset chainman in ~ChainstateManager instead.Jul 15 2022, 08:29

Fabien accepted this revision.Jul 15 2022, 09:33

This revision is now accepted and ready to land.Jul 15 2022, 09:33

Closed by commit rABC9d99cccc3809: make FindBlockToFinalize a CChainState member (authored by PiRK). · Explain WhyJul 15 2022, 10:45

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC9d99cccc3809: make FindBlockToFinalize a CChainState member.

Revision Contents
Changeset List

Path

Size

src/

validation.h

3 lines

validation.cpp

5 lines

Diff 34362

View Options

src/validation.h