Page MenuHomePhabricator

[avalanche] Request more peers for their avalanche nodes
ClosedPublic

Authored by Fabien on Tue, Jul 19, 16:08.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABCcb78d2179d2d: [avalanche] Request more peers for their avalanche nodes
Summary

Actually the periodic avalanche address request is targeting one peer at a time. This diff makes the node requesting all peers while our quorum is not established or if we should request more because of no suitable node found for polling or dangling proof.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Tue, Jul 19, 16:08
sdulfari requested changes to this revision.Tue, Jul 19, 16:26
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
test/functional/abc_p2p_getavaaddr.py
259 ↗(On Diff #34419)

The actual number may change. No reason to tie the function name to the number.

This revision now requires changes to proceed.Tue, Jul 19, 16:26

Make the number of targets a parameter

Fabien planned changes to this revision.Tue, Jul 19, 19:02

Let's evaluate if we can/should request them all

Rebase, request all the peers

sdulfari requested changes to this revision.Sat, Jul 23, 06:01
sdulfari added inline comments.
src/net_processing.cpp
1719 ↗(On Diff #34481)
test/functional/abc_p2p_getavaaddr.py
255–256 ↗(On Diff #34481)
This revision now requires changes to proceed.Sat, Jul 23, 06:01
Fabien planned changes to this revision.Wed, Jul 27, 17:55
sdulfari requested changes to this revision.Thu, Jul 28, 17:07
sdulfari added inline comments.
src/net_processing.cpp
1685–1698 ↗(On Diff #34544)

This simplifies the g_avalanche checks.

This revision now requires changes to proceed.Thu, Jul 28, 17:07
This revision is now accepted and ready to land.Fri, Jul 29, 18:42