Page MenuHomePhabricator

[avalanche] Request more peers for their avalanche nodes
ClosedPublic

Authored by Fabien on Jul 19 2022, 16:08.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABCcb78d2179d2d: [avalanche] Request more peers for their avalanche nodes
Summary

Actually the periodic avalanche address request is targeting one peer at a time. This diff makes the node requesting all peers while our quorum is not established or if we should request more because of no suitable node found for polling or dangling proof.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_getavaaddr_more_peers
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19665
Build 39049: Build Diffbuild-without-wallet · lint-circular-dependencies · build-clang-tidy · build-clang · build-diff · build-debug
Build 39048: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Jul 19 2022, 16:08
sdulfari requested changes to this revision.Jul 19 2022, 16:26
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
test/functional/abc_p2p_getavaaddr.py
259

The actual number may change. No reason to tie the function name to the number.

This revision now requires changes to proceed.Jul 19 2022, 16:26

Make the number of targets a parameter

Fabien planned changes to this revision.Jul 19 2022, 19:02

Let's evaluate if we can/should request them all

Rebase, request all the peers

sdulfari requested changes to this revision.Jul 23 2022, 06:01
sdulfari added inline comments.
src/net_processing.cpp
1719 ↗(On Diff #34481)
test/functional/abc_p2p_getavaaddr.py
255–256 ↗(On Diff #34481)
This revision now requires changes to proceed.Jul 23 2022, 06:01
Fabien planned changes to this revision.Jul 27 2022, 17:55
sdulfari requested changes to this revision.Jul 28 2022, 17:07
sdulfari added inline comments.
src/net_processing.cpp
1685–1698 ↗(On Diff #34544)

This simplifies the g_avalanche checks.

This revision now requires changes to proceed.Jul 28 2022, 17:07
This revision is now accepted and ready to land.Jul 29 2022, 18:42