Page MenuHomePhabricator

Backport various improvement to test_framework.py
ClosedPublic

Authored by deadalnix on Mar 6 2018, 10:36.

Details

Summary

Backport several PRs and commits, plus fix a few nits.

PR #10318: [tests] fix wait_for_inv()

3e3c22f [tests] fix wait_for_inv() (John Newbery)

PR #10124: [test] Suppress test logging spam

45ce471 Reduce spammy test logging (John Newbery)

Commit a7820422e (Part of PR #11319)

qa: Treat mininode p2p exceptions as fatal (Suhas Daftuar)
Test Plan
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
mininodemodernize
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2023
Build 2194: Bitcoin ABC Buildbot (legacy)
Build 2193: arc lint + arc unit

Event Timeline

This is broken.

Backports introduced the same race condition that was fixed in D284 . Fixed again :)
Fix a bug in abc-p2p-compactblocks where the network thread is started twice.

Rebase and nit tweak some logs

schancel edited the summary of this revision. (Show Details)

Updated the description and removed reference to PR #11078

This revision is now accepted and ready to land.Mar 7 2018, 19:08
This revision was automatically updated to reflect the committed changes.