Page MenuHomePhabricator
Differential D12053

[Cashtab] [chronik tx history p4] move parseChronikTx from cashMethods to chronik
ClosedPublic
Actions

Authored by bytesofman on Sep 23 2022, 19:52.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCb1146b4a9f3b: [Cashtab] [chronik tx history p4] move parseChronikTx from cashMethods to…
Summary

T2447

Depends on D12052

Move the parseChronikTx function out of cashMethods and into the chronik file. This function will be expanded to fully parse tx history using chronik.

Test Plan

npm test and unit tests still work after reshuffling location
npm start and no issues

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-for-tx-history-stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20168
Build 40021: Build Diffcashtab-tests
Build 40020: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sep 23 2022, 19:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2022, 19:52
bytesofman requested review of this revision.Sep 23 2022, 19:52
Harbormaster completed remote builds in B20168: Diff 35172.Sep 23 2022, 19:55
bytesofman updated this revision to Diff 35174.Sep 23 2022, 20:21

Define parseChronikTx before it is used in other function

Harbormaster completed remote builds in B20170: Diff 35174.Sep 23 2022, 20:23
bytesofman added a child revision: D12054: [Cashtab] [chronik tx history p5] get reply hash160.Sep 23 2022, 21:19
emack accepted this revision.Sep 24 2022, 16:02
This revision is now accepted and ready to land.Sep 24 2022, 16:02
bytesofman updated this revision to Diff 35376.Oct 3 2022, 23:49

rebase

Harbormaster completed remote builds in B20309: Diff 35376.Oct 3 2022, 23:50
teamcity added a comment.Oct 3 2022, 23:50
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Closed by commit rABCb1146b4a9f3b: [Cashtab] [chronik tx history p4] move parseChronikTx from cashMethods to… (authored by bytesofman). · Explain WhyOct 6 2022, 13:49
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCb1146b4a9f3b: [Cashtab] [chronik tx history p4] move parseChronikTx from cashMethods to….

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
2 lines
utils/
__mocks__/
210 lines
210 lines
__tests__/
57 lines
53 lines
95 lines
95 lines

Diff 35172

View Options

web/cashtab/src/hooks/useWallet.js

Loading...
View Options

web/cashtab/src/utils/__mocks__/chronikTxHistory.js

Loading...
View Options

web/cashtab/src/utils/__mocks__/chronikWs.js

Loading...
View Options

web/cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

web/cashtab/src/utils/__tests__/chronik.test.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...
View Options

web/cashtab/src/utils/chronik.js

Loading...