Page MenuHomePhabricator
Differential D12054

[Cashtab] [chronik tx history p5] get reply hash160
ClosedPublic
Actions

Authored by bytesofman on Sep 23 2022, 21:19.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCb0df15a5c6c0: [Cashtab] [chronik tx history p5] get reply hash160
Summary

T2447

Depends on D12053

Modify parseChronikTx to also get the address that created the tx. This is used for the replyAddress feature in Cashtab's tx history.

Test Plan

npm test, review unit test updates
npm start. Send and receive txs. Observe the originatingHash160 in tx history matches your wallet for sent txs, and matches the sending wallet for received txs.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-for-tx-history-stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20171
Build 40027: Build Diffcashtab-tests
Build 40026: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sep 23 2022, 21:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2022, 21:19
bytesofman requested review of this revision.Sep 23 2022, 21:19
Harbormaster completed remote builds in B20171: Diff 35175.Sep 23 2022, 21:22
emack accepted this revision.Sep 25 2022, 02:12
emack added a subscriber: emack.

Verified via https://cointools.org/address-to-hash/?address=1NtuDs56LgGNAm45NXzuYnfqcYuuzJ5gCS converting eCash address -> legacy address -> hash160

This revision is now accepted and ready to land.Sep 25 2022, 02:12
bytesofman added a child revision: D12056: [Cashtab] [chronik tx history p6] Detect OP_RETURN msgs and run through existing parse function.Sep 25 2022, 05:06
bytesofman updated this revision to Diff 35377.Oct 3 2022, 23:49

rebase

Harbormaster completed remote builds in B20310: Diff 35377.Oct 3 2022, 23:59
Closed by commit rABCb0df15a5c6c0: [Cashtab] [chronik tx history p5] get reply hash160 (authored by bytesofman). · Explain WhyOct 6 2022, 13:49
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCb0df15a5c6c0: [Cashtab] [chronik tx history p5] get reply hash160.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
2 lines
utils/
__tests__/
4 lines
42 lines

Diff 35175

View Options

web/cashtab/src/hooks/useWallet.js

Loading...
View Options

web/cashtab/src/utils/__tests__/chronik.test.js

Loading...
View Options

web/cashtab/src/utils/chronik.js

Loading...