Page MenuHomePhabricator

[Cashtab] [chronik tx history p5] get reply hash160
ClosedPublic

Authored by bytesofman on Sep 23 2022, 21:19.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCb0df15a5c6c0: [Cashtab] [chronik tx history p5] get reply hash160
Summary

T2447

Depends on D12053

Modify parseChronikTx to also get the address that created the tx. This is used for the replyAddress feature in Cashtab's tx history.

Test Plan

npm test, review unit test updates
npm start. Send and receive txs. Observe the originatingHash160 in tx history matches your wallet for sent txs, and matches the sending wallet for received txs.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-for-tx-history-stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20171
Build 40027: Build Diffcashtab-tests
Build 40026: arc lint + arc unit

Event Timeline

emack added a subscriber: emack.

Verified via https://cointools.org/address-to-hash/?address=1NtuDs56LgGNAm45NXzuYnfqcYuuzJ5gCS converting eCash address -> legacy address -> hash160

This revision is now accepted and ready to land.Sep 25 2022, 02:12