Page MenuHomePhabricator
Differential D12066

[Cashtab] [chronik tx history p7] duplicate most legacy tx data
ClosedPublic
Actions

Authored by bytesofman on Sep 26 2022, 23:11.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC8de6340c0620: [Cashtab] [chronik tx history p7] duplicate most legacy tx data
Summary

T2447

Depends on D12056

Duplicate most data required by Tx.js to render tx history. Put it in a legacy object so it can match rendering.

Test Plan

Review the updated change (requiring wallet as input to deal with encrypted msgs), it's impact on mocks and tests, and npm test

npm start and check the legacy field of parsedTxs for correct OP_RETURN msg parsing

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-for-tx-history-stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20188
Build 40061: Build Diffcashtab-tests
Build 40060: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sep 26 2022, 23:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2022, 23:11
bytesofman requested review of this revision.Sep 26 2022, 23:11
Harbormaster completed remote builds in B20187: Diff 35199.Sep 26 2022, 23:14
bytesofman updated this revision to Diff 35200.Sep 26 2022, 23:15

Updating dev log info

Harbormaster completed remote builds in B20188: Diff 35200.Sep 26 2022, 23:17
emack accepted this revision.Sep 27 2022, 08:54
This revision is now accepted and ready to land.Sep 27 2022, 08:54
bytesofman updated this revision to Diff 35379.Oct 3 2022, 23:49

rebase

Harbormaster completed remote builds in B20312: Diff 35379.Oct 4 2022, 00:02
bytesofman added a child revision: D12089: [Cashtab] [chronik tx history p8] Add replyAddress to legacy object.Oct 4 2022, 14:06
Closed by commit rABC8de6340c0620: [Cashtab] [chronik tx history p7] duplicate most legacy tx data (authored by bytesofman). · Explain WhyOct 6 2022, 13:49
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC8de6340c0620: [Cashtab] [chronik tx history p7] duplicate most legacy tx data.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
10 lines
utils/
__mocks__/
50 lines
__tests__/
62 lines
198 lines

Diff 35200

View Options

web/cashtab/src/hooks/useWallet.js

Loading...
View Options

web/cashtab/src/utils/__mocks__/chronikTxHistory.js

Loading...
View Options

web/cashtab/src/utils/__tests__/chronik.test.js

Loading...
View Options

web/cashtab/src/utils/chronik.js

Loading...