Page MenuHomePhabricator
Differential D12130

[Cashtab] [chronik tx history p10] Parse etokenAmount for token decimals
ClosedPublic
Actions

Authored by bytesofman on Oct 3 2022, 23:01.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCa44c6d600129: [Cashtab] [chronik tx history p10] Parse etokenAmount for token decimals
Summary

T2447

Depends on D12129

Add support for parsing token decimals to parseChronikTx so that etokenAmount is correct for any given etoken

Test Plan

Review new unit test + old mod and npm test
npm start and send or receive an etoken tx with multiple decimal places, review console.log output to confirm etokenAmount is correct for that tx

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-for-tx-history-stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20304
Build 40282: Build Diffcashtab-tests
Build 40281: arc lint + arc unit

Event Timeline

bytesofman created this revision.Oct 3 2022, 23:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2022, 23:01
bytesofman requested review of this revision.Oct 3 2022, 23:01
Harbormaster completed remote builds in B20304: Diff 35371.Oct 3 2022, 23:01
teamcity added a comment.Oct 3 2022, 23:01
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman added a child revision: D12131: [Cashtab] [chronik tx history p11] Update incoming tx notifications parsing to use new function.Oct 3 2022, 23:46
bytesofman updated this revision to Diff 35382.Oct 3 2022, 23:50

rebase

Harbormaster completed remote builds in B20315: Diff 35382.Oct 3 2022, 23:53
emack accepted this revision.Oct 5 2022, 07:35
This revision is now accepted and ready to land.Oct 5 2022, 07:35
Closed by commit rABCa44c6d600129: [Cashtab] [chronik tx history p10] Parse etokenAmount for token decimals (authored by bytesofman). · Explain WhyOct 6 2022, 13:49
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCa44c6d600129: [Cashtab] [chronik tx history p10] Parse etokenAmount for token decimals.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
1 line
utils/
__mocks__/
612 lines
__tests__/
83 lines
32 lines

Diff 35371

View Options

web/cashtab/src/hooks/useWallet.js

Loading...
View Options

web/cashtab/src/utils/__mocks__/chronikTxHistory.js

Loading...
View Options

web/cashtab/src/utils/__tests__/chronik.test.js

Loading...
View Options

web/cashtab/src/utils/chronik.js

Loading...