T2447
Depends on D12139
Remove all legacy tx history parsing functions associated with the bch-api approach. Also remove their related unit tests and mocks.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABCf5ad7d2fb8e3: [Cashtab] [chronik tx history p14]Remove legacy tx parsing functions, tests…
Review removed functions. grep -r <functionName> src/ for each to confirm they are not used anywhere else in the codebase.
npm start and app still works
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- chronik-for-tx-history-stack
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20346 Build 40365: Build Diff cashtab-tests Build 40364: arc lint + arc unit
Event Timeline
Comment Actions
- to avoid new dev confusion in chronik.js:
change:
// Defining variables used in lines legacy parseTxData function from useBCH.js
to
// Defining variables used in line with the now removed legacy parseTxData function from useBCH.js
- Also I'm seeing a reference to getTxHistory() in useWallet.js.rej - can we ignore this as this seems to be a arc patch artefact?
Otherwise app tested all ok after these deprecations. If anything, the speed improvement from this diff is VERY noticeable.
Comment Actions
- to avoid new dev confusion in chronik.js:
change:
// Defining variables used in lines legacy parseTxData function from useBCH.js
to
// Defining variables used in line with the now removed legacy parseTxData function from useBCH.js
- Also I'm seeing a reference to getTxHistory() in useWallet.js.rej - can we ignore this as this seems to be a arc patch artefact?
Otherwise app tested all ok after these deprecations. If anything, the speed improvement from this diff is VERY noticeable.
Handled this in D12148
Diffs after this make the comment obsolete
Comment Actions
- Also I'm seeing a reference to getTxHistory() in useWallet.js.rej - can we ignore this as this seems to be a arc patch artefact?
Yeah you can just delete the file.