Page MenuHomePhabricator

[Cashtab] [chronik tx history p15] parsing token burn txs
ClosedPublic

Authored by bytesofman on Oct 4 2022, 22:42.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC10c9f21d563d: [Cashtab] [chronik tx history p15] parsing token burn txs
Summary

T2447

Depends on D12140

Parse chronik token burn information and display it in tx history

Test Plan

Review new unit tests and npm test
npm start, burn some of an eToken, confirm the tx is rendered correctly in tx history

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-for-tx-history-stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20350
Build 40373: Build Diffcashtab-tests
Build 40372: arc lint + arc unit

Event Timeline

emack requested changes to this revision.EditedOct 5 2022, 14:08
emack added a subscriber: emack.

Burning partial amount of tokens works fine however when you choose to burn the entire balance of the token it gets into a continuous loop when it routes back to the TxHistory screen as below:

It's getting stuck somewhere after 'chronikTxHistory as flatterend array, sorted by...' and before the 'tokenInfoById' update, so it could be related to the caching of token info in cashtabCache. i.e. when the full balance is burnt, I don't think I've seen any diff that removes it from token cache. Not sure if that is causing this.

Having said that, the tx history is still getting updated with the burn tx all ok, so there's probably a gap somewhere that is not recognizing the burn token tx as part of the usual utxo update and thus not removing the passLoadingStatus.

This revision now requires changes to proceed.Oct 5 2022, 14:08

Burning partial amount of tokens works fine however when you choose to burn the entire balance of the token it gets into a continuous loop when it routes back to the TxHistory screen as below:

It's getting stuck somewhere after 'chronikTxHistory as flatterend array, sorted by...' and before the 'tokenInfoById' update, so it could be related to the caching of token info in cashtabCache. i.e. when the full balance is burnt, I don't think I've seen any diff that removes it from token cache. Not sure if that is causing this.

Having said that, the tx history is still getting updated with the burn tx all ok, so there's probably a gap somewhere that is not recognizing the burn token tx as part of the usual utxo update and thus not removing the passLoadingStatus.

I'm able to recreate this. I've created a separate task for this issue at T2716, which exists in prod at Cashtab.com and does not appear related to this diff.

This revision is now accepted and ready to land.Oct 5 2022, 23:12