Page MenuHomePhabricator
Differential D12148

[Cashtab] [chronik tx history p19] remove legacy object from tx parsing
ClosedPublic
Actions

Authored by bytesofman on Oct 4 2022, 23:48.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC6600ead38e40: [Cashtab] [chronik tx history p19] remove legacy object from tx parsing
Summary

T2447

Depends on D12147

Remove legacy object. Keep remaining legacy parameters in new parsed object as they are unique and still used.

Test Plan

Review changes to unit tests and npm test
npm start and txs still render correctly

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-for-tx-history-stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20356
Build 40385: Build Diffcashtab-tests
Build 40384: arc lint + arc unit

Event Timeline

bytesofman created this revision.Oct 4 2022, 23:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2022, 23:48
bytesofman requested review of this revision.Oct 4 2022, 23:48
Harbormaster completed remote builds in B20356: Diff 35428.Oct 4 2022, 23:50
bytesofman updated this revision to Diff 35459.Oct 5 2022, 18:32

Removing obsolete comment

bytesofman mentioned this in D12140: [Cashtab] [chronik tx history p14]Remove legacy tx parsing functions, tests, and mocks.Oct 5 2022, 18:32
Harbormaster completed remote builds in B20370: Diff 35459.Oct 5 2022, 18:34
emack accepted this revision.Oct 6 2022, 03:13
This revision is now accepted and ready to land.Oct 6 2022, 03:13
bytesofman added a child revision: D12158: [Cashtab] [chronik tx history p20] update token info cache in tx history routine.Oct 6 2022, 03:44
Closed by commit rABC6600ead38e40: [Cashtab] [chronik tx history p19] remove legacy object from tx parsing (authored by bytesofman). · Explain WhyOct 6 2022, 13:49
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC6600ead38e40: [Cashtab] [chronik tx history p19] remove legacy object from tx parsing.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Home/
64 lines
utils/
__tests__/
182 lines
32 lines

Diff 35428

View Options

web/cashtab/src/components/Home/Tx.js

Loading...
View Options

web/cashtab/src/utils/__tests__/chronik.test.js

Loading...
View Options

web/cashtab/src/utils/chronik.js

Loading...