Paths

Table of Contentst

Differential D12235

[validation] Add CChainStateManager::ProcessTransaction() and use it outside validation
ClosedPublic
Actions

Authored by PiRK on Oct 13 2022, 08:50.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC924ee9eb564a: [validation] Add CChainStateManager::ProcessTransaction() and use it outside…

Summary

Also add a new transaction validation failure reason TX_NO_MEMPOOL to indicate that there is no mempool.

This is a backport of core#23173
https://github.com/bitcoin/bitcoin/pull/23173/commits/92a3aeecf6a82e9cbc9fda11022b0548efd24d05
https://github.com/bitcoin/bitcoin/pull/23173/commits/2c64270bbe523ef87e7225c351464e7c716f0b3e

Note: due to D1667, there are calls to AcceptToMemoryPool in DisconnectedBlockTransactions::updateMempoolForReorg that cannot access the chain manager.
However updateMempoolForReorg is only called from within validation.cpp, so it should not be a problem.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20484
Build 40640: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang · build-bench
Build 40639: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 13 2022, 08:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 13 2022, 08:50

PiRK requested review of this revision.Oct 13 2022, 08:50

teamcity edited the summary of this revision. (Show Details)Oct 13 2022, 08:50

PiRK added a child revision: D12236: [validation] Always call mempool.check() after processing a new transaction.Oct 13 2022, 08:52

Harbormaster completed remote builds in B20484: Diff 35643.Oct 13 2022, 09:30

Fabien accepted this revision.Oct 13 2022, 14:30

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/validation.h
338	config is missing

This revision is now accepted and ready to land.Oct 13 2022, 14:30

add doxygen doc for config param

PiRK mentioned this in D12238: Remove AcceptToMemoryPoolWithTime.Oct 13 2022, 15:50

Harbormaster completed remote builds in B20493: Diff 35663.Oct 13 2022, 15:56

Closed by commit rABC924ee9eb564a: [validation] Add CChainStateManager::ProcessTransaction() and use it outside… (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyOct 13 2022, 16:22

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC924ee9eb564a: [validation] Add CChainStateManager::ProcessTransaction() and use it outside….

Revision Contents
Changeset List

Path

Size

src/

bench/

block_assemble.cpp

6 lines

consensus/

2 lines

net_processing.cpp

19 lines

node/

transaction.cpp

11 lines

rpc/

rawtransaction.cpp

8 lines

test/

txvalidation_tests.cpp

5 lines

txvalidationcache_tests.cpp

5 lines

util/

setup_common.cpp

6 lines

validation_block_tests.cpp

4 lines

30 lines

18 lines

Diff 35643

src/bench/block_assemble.cpp

Loading...

src/consensus/validation.h

Loading...

src/net_processing.cpp

Loading...

src/node/transaction.cpp

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/test/txvalidation_tests.cpp

Loading...

src/test/txvalidationcache_tests.cpp

Loading...

src/test/util/setup_common.cpp

Loading...

src/test/validation_block_tests.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...