[Cashtab] [Extension] [Code cleanup p2] Remove unused window variable from background.js
AbandonedPublic
Actions

Authored by bytesofman on Nov 15 2022, 14:29.

Details

Reviewers

kieran709

Group Reviewers

Restricted Project

Summary

T2751

Depends on D12501

The window is never used as a variable. Calling await openWindow does the same thing.

Test Plan

npm run extension
Update your local unpacked extension
Navigate to components.cashtab.com
Click on Cashtab Pay button for the standard Cashtab Badge component
Cashtab extension should open with tx populated

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20955
Build 41566: Build Diff	cashtab-tests
Build 41565: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 15 2022, 14:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2022, 14:29

bytesofman requested review of this revision.Nov 15 2022, 14:29

Harbormaster completed remote builds in B20927: Diff 36312.Nov 15 2022, 14:32

bytesofman mentioned this in D12504: [Cashtab] [Extension] [Code cleanup p4] Update comments and function name for triggerUi.Nov 15 2022, 14:40

kieran709 accepted this revision.Nov 15 2022, 15:59

This revision is now accepted and ready to land.Nov 15 2022, 15:59

rebase

Harbormaster completed remote builds in B20955: Diff 36351.Nov 16 2022, 17:20

bytesofman added a child revision: D12503: [Cashtab] [Extension] [Code cleanup p3] Remove commented out testing code from background.js.Nov 17 2022, 05:10

bytesofman abandoned this revision.Nov 21 2022, 10:09

Revision Contents
Changeset List

Path

Size

web/

cashtab/

extension/

src/

background.js

2 lines

Diff 36351

View Options

web/cashtab/extension/src/background.js

[Cashtab] [Extension] [Code cleanup p2] Remove unused window variable from background.jsAbandonedPublicActions