Paths

Table of Contentst

Differential D12664

[Cashtab] Deprecate BCH param from getChangeAddressFromInputUtxos function
ClosedPublic
Actions

Authored by bytesofman on Nov 28 2022, 05:58.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCc04a43810466: [Cashtab] Deprecate BCH param from getChangeAddressFromInputUtxos function

Summary

T2730

Depends on D12663

Remove BCH param from getChangeAddressFromInputUtxos function. The param is not used in this function and exists there as an artifact.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 28 2022, 05:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2022, 05:58

bytesofman requested review of this revision.Nov 28 2022, 05:58

Harbormaster completed remote builds in B21205: Diff 36731.Nov 28 2022, 06:01

bytesofman added a child revision: D12665: [Cashtab] Deprecate BCH param from generateTxOutput function.Nov 28 2022, 06:03

emack accepted this revision.Nov 29 2022, 13:48

This revision is now accepted and ready to land.Nov 29 2022, 13:48

Closed by commit rABCc04a43810466: [Cashtab] Deprecate BCH param from getChangeAddressFromInputUtxos function (authored by bytesofman). · Explain WhyNov 29 2022, 15:53

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCc04a43810466: [Cashtab] Deprecate BCH param from getChangeAddressFromInputUtxos function.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

useBCH.js

1 line

utils/

__tests__/

cashMethods.test.js

16 lines

cashMethods.js

4 lines

Diff 36779

View Options

web/cashtab/src/hooks/useBCH.js

View Options

web/cashtab/src/utils/tests/cashMethods.test.js

View Options

web/cashtab/src/utils/cashMethods.js

[Cashtab] Deprecate BCH param from getChangeAddressFromInputUtxos functionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36779

web/cashtab/src/hooks/useBCH.js

web/cashtab/src/utils/__tests__/cashMethods.test.js

web/cashtab/src/utils/cashMethods.js

[Cashtab] Deprecate BCH param from getChangeAddressFromInputUtxos function
ClosedPublic
Actions

Revision Contents
Changeset List

web/cashtab/src/utils/tests/cashMethods.test.js