Paths

Table of Contentst

Differential D12666

[Cashtab] Deprecate BCH param from signAndBuildTx function
ClosedPublic
Actions

Authored by bytesofman on Nov 28 2022, 06:08.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC128efd8850c7: [Cashtab] Deprecate BCH param from signAndBuildTx function

Summary

T2730

Depends on D12665

Deprecate BCH param from signAndBuildTx function. The param is not used in the function and exists as an artifact.

Test Plan

npm test
npm start and send an XEC tx
grep -r signAndBuildTx src/ and make sure it's removed everywhere

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 28 2022, 06:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2022, 06:08

bytesofman requested review of this revision.Nov 28 2022, 06:08

Harbormaster completed remote builds in B21207: Diff 36733.Nov 28 2022, 06:11

bytesofman added a child revision: D12667: [Cashtab] Deprecate BCH param from getRecipientPublicKey function.Nov 28 2022, 06:13

emack accepted this revision.Nov 29 2022, 14:00

This revision is now accepted and ready to land.Nov 29 2022, 14:00

Closed by commit rABC128efd8850c7: [Cashtab] Deprecate BCH param from signAndBuildTx function (authored by bytesofman). · Explain WhyNov 29 2022, 15:53

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC128efd8850c7: [Cashtab] Deprecate BCH param from signAndBuildTx function.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

useBCH.js

16 lines

utils/

__tests__/

cashMethods.test.js

38 lines

txBuilder.test.js

9 lines

cashMethods.js

3 lines

Diff 36781

View Options

web/cashtab/src/hooks/useBCH.js

View Options

web/cashtab/src/utils/tests/cashMethods.test.js

View Options

web/cashtab/src/utils/tests/txBuilder.test.js

View Options

web/cashtab/src/utils/cashMethods.js

[Cashtab] Deprecate BCH param from signAndBuildTx functionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36781

web/cashtab/src/hooks/useBCH.js

web/cashtab/src/utils/__tests__/cashMethods.test.js

web/cashtab/src/utils/__tests__/txBuilder.test.js

web/cashtab/src/utils/cashMethods.js

[Cashtab] Deprecate BCH param from signAndBuildTx function
ClosedPublic
Actions

Revision Contents
Changeset List

web/cashtab/src/utils/tests/cashMethods.test.js

web/cashtab/src/utils/tests/txBuilder.test.js