Differential D12667

[Cashtab] Deprecate BCH param from getRecipientPublicKey function
ClosedPublic
Actions

Authored by bytesofman on Nov 28 2022, 06:13.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCd6fb91df93eb: [Cashtab] Deprecate BCH param from getRecipientPublicKey function

Summary

T2730

Depends on D12666

Remove BCH param from getRecipientPublicKey function. The param is not used and exists as an artifact.

Test Plan

npm test
npm start and send an encrypted msg tx
grep -r getRecipientPublicKey src/ and ensure it's removed from all instances

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 28 2022, 06:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2022, 06:13

bytesofman requested review of this revision.Nov 28 2022, 06:13

bytesofman mentioned this in D12558: [Cashtab] Remove unused param from function.Nov 28 2022, 06:13

Harbormaster completed remote builds in B21208: Diff 36734.Nov 28 2022, 06:16

bytesofman added a child revision: D12668: [Cashtab] Deprecate BCH param from sendXec.Nov 28 2022, 06:22

emack accepted this revision.Nov 29 2022, 13:35

This revision is now accepted and ready to land.Nov 29 2022, 13:35

Closed by commit rABCd6fb91df93eb: [Cashtab] Deprecate BCH param from getRecipientPublicKey function (authored by bytesofman). · Explain WhyNov 29 2022, 15:53

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCd6fb91df93eb: [Cashtab] Deprecate BCH param from getRecipientPublicKey function.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

__tests__/

useBCH.test.js

2 lines

useBCH.js

2 lines

Diff 36782

View Options

web/cashtab/src/hooks/tests/useBCH.test.js

View Options

web/cashtab/src/hooks/useBCH.js

[Cashtab] Deprecate BCH param from getRecipientPublicKey functionClosedPublicActions