Paths

Table of Contentst

Differential D12665

[Cashtab] Deprecate BCH param from generateTxOutput function
ClosedPublic
Actions

Authored by bytesofman on Nov 28 2022, 06:02.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCe49c2df8af03: [Cashtab] Deprecate BCH param from generateTxOutput function

Summary

T2730

Depends on D12664

Deprecate BCH param from generateTxOutput function. The param is there only as an artifact and is not used in the function.

Test Plan

npm test
grep -r generatTxOutput src/ and make sure the param is removed from all instances of the function
npm start and send an XEC tx

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 28 2022, 06:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2022, 06:02

bytesofman requested review of this revision.Nov 28 2022, 06:02

bytesofman edited the summary of this revision. (Show Details)Nov 28 2022, 06:03

bytesofman added a parent revision: D12664: [Cashtab] Deprecate BCH param from getChangeAddressFromInputUtxos function.

Harbormaster completed remote builds in B21206: Diff 36732.Nov 28 2022, 06:05

bytesofman added a child revision: D12666: [Cashtab] Deprecate BCH param from signAndBuildTx function.Nov 28 2022, 06:08

Small nit on the generatTxOutput typo in the test plan

This revision is now accepted and ready to land.Nov 29 2022, 13:54

Closed by commit rABCe49c2df8af03: [Cashtab] Deprecate BCH param from generateTxOutput function (authored by bytesofman). · Explain WhyNov 29 2022, 15:53

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCe49c2df8af03: [Cashtab] Deprecate BCH param from generateTxOutput function.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

useBCH.js

1 line

utils/

__tests__/

cashMethods.test.js

12 lines

txBuilder.test.js

1 line

cashMethods.js

2 lines

Diff 36780

View Options

web/cashtab/src/hooks/useBCH.js

View Options

web/cashtab/src/utils/tests/cashMethods.test.js

View Options

web/cashtab/src/utils/tests/txBuilder.test.js

View Options

web/cashtab/src/utils/cashMethods.js

[Cashtab] Deprecate BCH param from generateTxOutput functionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36780

web/cashtab/src/hooks/useBCH.js

web/cashtab/src/utils/__tests__/cashMethods.test.js

web/cashtab/src/utils/__tests__/txBuilder.test.js

web/cashtab/src/utils/cashMethods.js

[Cashtab] Deprecate BCH param from generateTxOutput function
ClosedPublic
Actions

Revision Contents
Changeset List

web/cashtab/src/utils/tests/cashMethods.test.js

web/cashtab/src/utils/tests/txBuilder.test.js