[net processing] Default initialize m_recent_confirmed_transactions
ClosedPublic
Actions

Authored by PiRK on Mar 17 2023, 15:48.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC5004aebbf8b6: [net processing] Default initialize m_recent_confirmed_transactions

Summary

Now that m_recent_confirmed_transactions is owned by PeerManagerImpl,
and PeerManagerImpl's lifetime is managed by the node context, we can
just default initialize m_recent_confirmed_transactions during object
initialization. We can also remove the unique_ptr indirection.

This concludes backport of core#21562
https://github.com/bitcoin/bitcoin/pull/21562/commits/fde1bf4f6136638e84cdf9806eedaae08e841bbf

Depends on D13379

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr21562

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22524
Build 44668: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-debug · build-clang-tidy · build-clang
Build 44667: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 17 2023, 15:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2023, 15:48

PiRK requested review of this revision.Mar 17 2023, 15:48

teamcity edited the summary of this revision. (Show Details)Mar 17 2023, 15:49

PiRK added inline comments.Mar 17 2023, 15:54

src/net_processing.cpp
758	24'000 vs 48'000 is because we don't have the wtxid to store in that filter in addition to the txids (https://github.com/bitcoin/bitcoin/commit/144c38582042c3b9ec53bb97ba0644fc0114f8fb)