Page MenuHomePhabricator

[alias-server] Improve mocked chronik class
ClosedPublic

Authored by bytesofman on Apr 6 2023, 17:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC76291027e9b9: [alias-server] Improve mocked chronik class
Summary

T3060

Depends on D13604

Improvements to chronikMock.js to make unit tests more effective. Confirm that initializeWebsocket called expected functions.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-functions-address-input
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23049
Build 45718: Build Diffalias-server-tests
Build 45717: arc lint + arc unit

Event Timeline

Improve unit test, patch bug caught by unit test

Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/alias-server/src/websocket.js
34 ↗(On Diff #39366)
apps/alias-server/test/mocks/chronikMock.js
26 ↗(On Diff #39366)

not very useful as a comment

This revision is now accepted and ready to land.Apr 7 2023, 08:24