Page MenuHomePhabricator
Differential D13605

[alias-server] Improve mocked chronik class
ClosedPublic
Actions

Authored by bytesofman on Apr 6 2023, 17:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC76291027e9b9: [alias-server] Improve mocked chronik class
Summary

T3060

Depends on D13604

Improvements to chronikMock.js to make unit tests more effective. Confirm that initializeWebsocket called expected functions.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Apr 6 2023, 17:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 6 2023, 17:49
bytesofman requested review of this revision.Apr 6 2023, 17:49
Harbormaster completed remote builds in B23049: Diff 39365.Apr 6 2023, 17:50
bytesofman updated this revision to Diff 39366.Apr 6 2023, 17:55

Improve unit test, patch bug caught by unit test

bytesofman added a child revision: D13606: [alias-server] Remove irrelevant comments.Apr 6 2023, 17:56
Harbormaster completed remote builds in B23050: Diff 39366.Apr 6 2023, 17:56
Fabien accepted this revision.Apr 7 2023, 08:24
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/alias-server/src/websocket.js
34 ↗(On Diff #39366)
apps/alias-server/test/mocks/chronikMock.js
26 ↗(On Diff #39366)

not very useful as a comment

This revision is now accepted and ready to land.Apr 7 2023, 08:24
Closed by commit rABC76291027e9b9: [alias-server] Improve mocked chronik class (authored by bytesofman). · Explain WhyApr 7 2023, 15:06
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC76291027e9b9: [alias-server] Improve mocked chronik class.

Revision Contents
Changeset List

PathSize
apps/
alias-server/
src/
2 lines
test/
mocks/
72 lines
11 lines

Diff 39397

View Options

apps/alias-server/src/websocket.js

Loading...
View Options

apps/alias-server/test/mocks/chronikMock.js

Loading...
View Options

apps/alias-server/test/websocketTests.js

Loading...