Page MenuHomePhabricator
Differential D13616

[herald] Unit tests for initializing websocket
ClosedPublic
Actions

Authored by bytesofman on Apr 7 2023, 16:35.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC423960e0f8ef: [herald] Unit tests for initializing websocket
Summary

T2972

Depends on D13615

Refactor websocket functions to accept chronik and telegramBot as params, as these must be mocked in unit tests.

Add unit tests for initializing the websocket.

Note: additional unit tests to follow later in this stack

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-refactor-stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23079
Build 45778: Build Diffecash-herald-tests
Build 45777: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 7 2023, 16:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 7 2023, 16:35
bytesofman requested review of this revision.Apr 7 2023, 16:35
Harbormaster completed remote builds in B23078: Diff 39403.Apr 7 2023, 16:35
bytesofman updated this revision to Diff 39404.Apr 7 2023, 16:36

lint fix

Harbormaster completed remote builds in B23079: Diff 39404.Apr 7 2023, 16:37
bytesofman added a child revision: D13617: [herald] Unit tests for parseWebsocketMessage.Apr 7 2023, 17:33
bytesofman updated this revision to Diff 39408.Apr 7 2023, 17:40

Removing unused db param

Harbormaster completed remote builds in B23083: Diff 39408.Apr 7 2023, 17:41
Fabien accepted this revision.Apr 9 2023, 06:31
This revision is now accepted and ready to land.Apr 9 2023, 06:31
bytesofman updated this revision to Diff 39492.Apr 10 2023, 16:30

rebase

Harbormaster completed remote builds in B23157: Diff 39492.Apr 10 2023, 16:30
Closed by commit rABC423960e0f8ef: [herald] Unit tests for initializing websocket (authored by bytesofman). · Explain WhyApr 12 2023, 14:26
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC423960e0f8ef: [herald] Unit tests for initializing websocket.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
2 lines
13 lines
30 lines
1 line
src/
28 lines
test/
mocks/
71 lines
66 lines

Diff 39404

View Options

apps/ecash-herald/config.js

Loading...
View Options

apps/ecash-herald/index.js

Loading...
View Options

apps/ecash-herald/package-lock.json

Loading...
View Options

apps/ecash-herald/package.json

Loading...
View Options

apps/ecash-herald/src/websocket.js

Loading...
View Options

apps/ecash-herald/test/mocks/chronikMock.js

Loading...
View Options

apps/ecash-herald/test/websocketTests.js

Loading...