Paths

Table of Contentst

Differential D13625

[herald] Fix instantiation of new telegramBot mock in websocket unit tests
ClosedPublic
Actions

Authored by bytesofman on Apr 7 2023, 22:34.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCb5199775ac81: [herald] Fix instantiation of new telegramBot mock in websocket unit tests

Summary

T2972

Depends on D13624

Overlooked error as these functions don't really use this param.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

herald-refactor-stack

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23093
Build 45806: Build Diff	ecash-herald-tests
Build 45805: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 7 2023, 22:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 7 2023, 22:34

bytesofman requested review of this revision.Apr 7 2023, 22:34

Harbormaster completed remote builds in B23093: Diff 39418.Apr 7 2023, 22:35

bytesofman added a child revision: D13627: [herald] Improve mocked chronik.Apr 8 2023, 12:07

Fabien accepted this revision.Apr 9 2023, 07:05

This revision is now accepted and ready to land.Apr 9 2023, 07:05

rebase

Harbormaster completed remote builds in B23165: Diff 39500.Apr 10 2023, 16:31

Closed by commit rABCb5199775ac81: [herald] Fix instantiation of new telegramBot mock in websocket unit tests (authored by bytesofman). · Explain WhyApr 12 2023, 14:26

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCb5199775ac81: [herald] Fix instantiation of new telegramBot mock in websocket unit tests.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

test/

websocketTests.js

4 lines

Diff 39418

View Options

apps/ecash-herald/test/websocketTests.js

[herald] Fix instantiation of new telegramBot mock in websocket unit testsClosedPublicActions