[wip] Start estimating tx fee based on size and utxos
AbandonedPublic
Actions

Authored by schancel on May 4 2018, 17:56.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Summary

Fee restructuring WIP, depends on D963

Test Plan

make check && ./test/functional/test_runner.py

Repository

rABC Bitcoin ABC

Branch

utxos

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2501
Build 3128: Bitcoin ABC Buildbot (legacy)
Build 3127: arc lint + arc unit

jasonbcox requested changes to this revision.May 6 2018, 18:18

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/test/policyestimator_tests.cpp
17	Is there any value to keeping this commented out? We should just remove it.
src/txmempool.cpp
943	Emperically -> Empirically And remove the trailing semicolon. lol
944	Can you write a comment on how 509 was chosen? Is this the number of bytes a typical 1-in-1-out tx would have?
948	Can we effectively annotate these values by making them static constants? I don't know what these numbers represent, even if they were gathered empirically.
src/txmempool.h
732	I thought we could use C++ optionals, but apparently that's only C++17: http://en.cppreference.com/w/cpp/utility/optional One day...