Page MenuHomePhabricator
Differential D13798

[arclint] Expand scope of `prettier` linter
ClosedPublic
Actions

Authored by bytesofman on Apr 26 2023, 18:46.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCef128a081bf8: [arclint] Expand scope of `prettier` linter
Summary

T3147

Depends on D13797

Expand target of prettier linter in arclint to include all relevant files in the monorepo and not just the web/ directory.
Add chronik-client .prettierignore targets to the exclude array

Test Plan

arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Apr 26 2023, 18:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 26 2023, 18:46
bytesofman requested review of this revision.Apr 26 2023, 18:46
Harbormaster completed remote builds in B23499: Diff 39994.Apr 26 2023, 18:46
PiRK accepted this revision.Apr 27 2023, 12:23
This revision is now accepted and ready to land.Apr 27 2023, 12:23
Closed by commit rABCef128a081bf8: [arclint] Expand scope of `prettier` linter (authored by bytesofman). · Explain WhyApr 27 2023, 13:17
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCef128a081bf8: [arclint] Expand scope of `prettier` linter.
PiRK added a comment.Apr 27 2023, 13:40

This causes a lot of lint errors and warnings in existing documentation, including archived release notes.

I have prettier 2.8.2 installed

bytesofman added a comment.Apr 27 2023, 14:12
In D13798#307611, @PiRK wrote:

This causes a lot of lint errors and warnings in existing documentation, including archived release notes.

I have prettier 2.8.2 installed

OK will check this out and see if a patch is more appropriate than revoking. But let me know if we need to just pull this out.

Fabien added a subscriber: Fabien.Apr 27 2023, 14:20
Fabien added inline comments.
.arclint
289

It might be enough to remove the md files

bytesofman added a comment.Apr 27 2023, 14:26

OK -- i'm running some tests now and excluding some directories. Going forward, will need to lint those directories first if we decide we want .arclint to apply prettier there

Fabien added a comment.Apr 27 2023, 14:52
In D13798#307653, @bytesofman wrote:

OK -- i'm running some tests now and excluding some directories. Going forward, will need to lint those directories first if we decide we want .arclint to apply prettier there

Yes.

Your test plan was running arc lint --everything so I expect all the files linted properly but this is not the case. The test plan doesn't pass, was not run and the diff should be reverted.

bytesofman added a reverting change: D13809: Revert "[arclint] Expand scope of `prettier` linter".Apr 27 2023, 15:05
bytesofman added a comment.Apr 27 2023, 15:05
In D13798#307669, @Fabien wrote:
In D13798#307653, @bytesofman wrote:

OK -- i'm running some tests now and excluding some directories. Going forward, will need to lint those directories first if we decide we want .arclint to apply prettier there

Yes.

Your test plan was running arc lint --everything so I expect all the files linted properly but this is not the case. The test plan doesn't pass, was not run and the diff should be reverted.

D13809

bytesofman added a reverting change: rABC21924e417700: Revert "[arclint] Expand scope of `prettier` linter".Apr 27 2023, 15:19

Revision Contents
Changeset List

PathSize
8 lines

Diff 40023

View Options

.arclint

Loading...