T3147
Depends on D13797
Expand target of prettier linter in arclint to include all relevant files in the monorepo and not just the web/ directory.
Add chronik-client .prettierignore targets to the exclude array
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABCef128a081bf8: [arclint] Expand scope of `prettier` linter
arc lint --everything
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- prettier-arclint-everything
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 23499 Build 46617: Build Diff Build 46616: arc lint + arc unit
Event Timeline
Comment Actions
This causes a lot of lint errors and warnings in existing documentation, including archived release notes.
I have prettier 2.8.2 installed
Comment Actions
OK will check this out and see if a patch is more appropriate than revoking. But let me know if we need to just pull this out.
| .arclint | ||
|---|---|---|
| 289 ↗ | (On Diff #40023) | It might be enough to remove the md files |
Comment Actions
OK -- i'm running some tests now and excluding some directories. Going forward, will need to lint those directories first if we decide we want .arclint to apply prettier there
Comment Actions
Yes.
Your test plan was running arc lint --everything so I expect all the files linted properly but this is not the case. The test plan doesn't pass, was not run and the diff should be reverted.