Differential D14017

Remove OutputGroup non-default constructors
ClosedPublic
Actions

Authored by Fabien on Jun 8 2023, 21:00.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCe0f238e52d0d: Remove OutputGroup non-default constructors

Summary

This a partial backport of core#20040:
https://github.com/bitcoin/bitcoin/pull/20040/commits/2acad036575ec998f8bbe4f10f6206b1c8ad3d23#diff-36ddaeb9e3a5c1aaaccd6b1ed6c770e8344e33dbfd4876b5f0726d84ab47cbab

There is no change in behavior.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR20040_p1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23953
Build 47516: Build Diff	build-without-wallet · build-clang · build-diff · build-debug · lint-circular-dependencies · build-bench · build-clang-tidy
Build 47515: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 8 2023, 21:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2023, 21:00

Fabien requested review of this revision.Jun 8 2023, 21:00

teamcity edited the summary of this revision. (Show Details)Jun 8 2023, 21:00

Fabien added a child revision: D14018: Move GroupOutputs into SelectCoinsMinConf.Jun 8 2023, 21:01

Harbormaster completed remote builds in B23953: Diff 40667.Jun 8 2023, 21:17

PiRK accepted this revision.Jun 9 2023, 05:36

This revision is now accepted and ready to land.Jun 9 2023, 05:36

Closed by commit rABCe0f238e52d0d: Remove OutputGroup non-default constructors (authored by Andrew Chow <achow101-github@achow101.com>, committed by Fabien). · Explain WhyJun 9 2023, 05:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe0f238e52d0d: Remove OutputGroup non-default constructors.

Revision Contents
Changeset List

Path

Size

src/

bench/

coin_selection.cpp

6 lines

wallet/

coinselection.h

9 lines

spend.cpp

3 lines

test/

coinselector_tests.cpp

8 lines

Diff 40667

View Options

src/bench/coin_selection.cpp

View Options

src/wallet/coinselection.h

View Options

src/wallet/spend.cpp

View Options

src/wallet/test/coinselector_tests.cpp

Remove OutputGroup non-default constructorsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40667

src/bench/coin_selection.cpp

src/wallet/coinselection.h

src/wallet/spend.cpp

src/wallet/test/coinselector_tests.cpp

Remove OutputGroup non-default constructors
ClosedPublic
Actions

Revision Contents
Changeset List