Differential D14020

Move EligibleForSpending into GroupOutputs
ClosedPublic
Actions

Authored by Fabien on Jun 8 2023, 21:02.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC1f415b29c79a: Move EligibleForSpending into GroupOutputs

Summary

Instead of filtering after the OutputGroups have been made, do it as they are being made.

This is a partial backport core#20040:
https://github.com/bitcoin/bitcoin/pull/20040/commits/d895e98b594b873f3d34c8ba63e9b55125d51b5a

Depends on D14019.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR20040_p4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23956
Build 47522: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 47521: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 8 2023, 21:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2023, 21:02

Fabien requested review of this revision.Jun 8 2023, 21:02

teamcity edited the summary of this revision. (Show Details)Jun 8 2023, 21:02

Fabien added a child revision: D14021: Move OutputGroup positive only filtering into Insert.Jun 8 2023, 21:03

Harbormaster completed remote builds in B23956: Diff 40670.Jun 8 2023, 21:35

PiRK accepted this revision.Jun 9 2023, 05:49

This revision is now accepted and ready to land.Jun 9 2023, 05:49

Closed by commit rABC1f415b29c79a: Move EligibleForSpending into GroupOutputs (authored by Andrew Chow <achow101-github@achow101.com>, committed by Fabien). · Explain WhyJun 9 2023, 05:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1f415b29c79a: Move EligibleForSpending into GroupOutputs.

Revision Contents
Changeset List

Path

Size

src/

wallet/

spend.h

3 lines

spend.cpp

41 lines

Diff 40670

View Options

src/wallet/spend.h