Page MenuHomePhabricator
Differential D14040

[depends] Use more recent config.guess and config.sub in various packages
ClosedPublic
Actions

Authored by PiRK on Jun 12 2023, 09:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd05f24bf6b92: [depends] Use more recent config.guess and config.sub in various packages
Summary

This might help with detecting arm64 when compiling some packages

This is a backport of https://github.com/bitcoin/bitcoin/pull/13665/commits/96dda8b0589affb88a909aaf62e95bebc4c18ba2

Depends on D14041

Test Plan
HOSTS="arm64-apple-darwin" contrib/guix/guix-build

This now successfuly compiles qrencode. The next failure happens with zmq.

Run gitian-builds on CI

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24015
Build 47640: Build Diff
Build 47639: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 12 2023, 09:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2023, 09:09
PiRK requested review of this revision.Jun 12 2023, 09:09
Harbormaster completed remote builds in B23995: Diff 40725.Jun 12 2023, 09:09
PiRK planned changes to this revision.Jun 12 2023, 09:10

The protobuf failure might be related to this change, actually.

Preprocessing protobuf...
cp: target 'gtest/build-aux' is not a directory
make: *** [funcs.mk:277: /bitcoin/depends/work/build/arm64-apple-darwin/protobuf/21.12-b4be8389631/.stamp_preprocessed] Error 1
make: Leaving directory '/bitcoin/depends'
PiRK updated this revision to Diff 40726.Jun 12 2023, 09:25
PiRK edited the test plan for this revision. (Show Details)

fix protobuf. Apparently the version we build does not have gtest/build-aux

Harbormaster completed remote builds in B23996: Diff 40726.Jun 12 2023, 09:25
PiRK updated this revision to Diff 40727.Jun 12 2023, 09:29

Just drop the change to protobuf.mk, it is not needed with our recent protobuf version

Harbormaster completed remote builds in B23997: Diff 40727.Jun 12 2023, 09:29
PiRK added a comment.Jun 12 2023, 09:50

@bot gitian-osx gitian-linux gitian-win

teamcity awarded a token.Jun 12 2023, 09:50
Fabien accepted this revision.Jun 12 2023, 12:27
This revision is now accepted and ready to land.Jun 12 2023, 12:27
PiRK updated this revision to Diff 40754.Jun 13 2023, 08:44
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D14041: build: copy config.{guess,sub} post autogen in zmq package.

rebase and update dependency (commits reordered so I can land the accepted ones without waiting for D14039)

Harbormaster completed remote builds in B24015: Diff 40754.Jun 13 2023, 08:44
PiRK added a child revision: D14042: [depends] bump jemalloc to 5.3.0.Jun 13 2023, 08:45
Closed by commit rABCd05f24bf6b92: [depends] Use more recent config.guess and config.sub in various packages (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by PiRK). · Explain WhyJun 13 2023, 09:05
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCd05f24bf6b92: [depends] Use more recent config.guess and config.sub in various packages.

Revision Contents
Changeset List

PathSize
depends/
packages/
4 lines
1 line
4 lines
4 lines

Diff 40754

View Options

depends/packages/libXau.mk

Loading...
View Options

depends/packages/libxcb.mk

Loading...
View Options

depends/packages/qrencode.mk

Loading...
View Options

depends/packages/xproto.mk

Loading...