Page MenuHomePhabricator

Increase the minerfund IFP reward
ClosedPublic

Authored by Fabien on Jun 15 2023, 15:27.

Details

Reviewers
Mengerian
PiRK
Group Reviewers
Restricted Project
Commits
rABC10577b475f3a: Increase the minerfund IFP reward
Summary

Bump the IFP reward starting on November 15, 2023.
This is done to maintain enough earnings for keeping the eCash project
moving forward despite the price getting lower during the bear market.

Test Plan
ninja check-extended

Event Timeline

Fabien requested review of this revision.Jun 15 2023, 15:27
Fabien changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Jun 15 2023, 15:27
Fabien changed the edit policy from "All Users" to "Restricted Project (Project)".
Fabien edited the summary of this revision. (Show Details)

The code looks good.

test/functional/abc_feature_minerfund.py
50 ↗(On Diff #40810)

The ratio parameter is not necessary in these subfunctions, as it is always equal to the ratio var from the outer scope.

Rebase, simplify the test as per review.
Note that this still lacking a release note.

FYI this will crash the price. Something to be aware of.

This revision is now accepted and ready to land.Oct 9 2023, 17:40
PiRK added inline comments.
src/test/minerfund_tests.cpp
84

The comment needs to be updated.

84 ↗(On Diff #42597)

the comment needs updating

This revision was automatically updated to reflect the committed changes.
Fabien changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Oct 9 2023, 20:25