[Cashtab][Alias] Deprecate alias history refresh in handleUpdateWallet
ClosedPublic
Actions

Authored by emack on Jul 1 2023, 15:33.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC420431d0ef4f: [Cashtab][Alias] Deprecate alias history refresh in handleUpdateWallet

Summary

T3216

Alias caching is now being incrementally deprecated in cashtab and alias data will be retrieved directly via api endpoints. Therefore removing the alias caching refresh trigger upon wallet load.

Test Plan

npm test
npm start
enable the aliasSettings.aliasEnabled flag in Ticker.js (will be moved in subsequent diff)
open dev conole and observe no logs relevant to getLatestAliases() upon app load
disable the aliasFlag, reload cashtab and ensure no logs relevant to getLatestAliases() upon app load

Diff Detail

Repository

rABC Bitcoin ABC

Branch

handleUpdateWallet

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24313
Build 48236: Build Diff	cashtab-tests
Build 48235: arc lint + arc unit

Event Timeline

emack created this revision.Jul 1 2023, 15:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2023, 15:33

emack requested review of this revision.Jul 1 2023, 15:33

Harbormaster completed remote builds in B24295: Diff 41160.Jul 1 2023, 15:36

bytesofman requested changes to this revision.Jul 1 2023, 21:30

bytesofman added inline comments.

cashtab/src/hooks/__tests__/useWallet.test.js
31 ↗	(On Diff #41160)	nice test that we should have in general i'm not sure why `isValidStoredWallet` does not also check for these keys. red flag that we need to write a custom validation function to use in an unrelated test...we should just have a validation function. My guess is that `isValidStoredWallet` has been around longer than the latest wallet shape we are using. In a separate diff, update `isValidStoredWallet` to check for these keys and deal with whatever test mocks might need to be updated to support this Update this test to use that function