Page MenuHomePhabricator

refactor: remove c-string interfaces for DecodeBase58{Check}
ClosedPublic

Authored by majcosta on Aug 24 2023, 11:15.

Details

Summary

This micro-PR gets rid of base58 function interfaces that are redundant in terms of c-string / std::string variants; the c-string interface for DecodeBase58Check is completely unused outside the base58 module, while the c-string interface for DecodeBase58 is only used in unit tests, where an implicit conversion to std::string is not problematic.

This is a backport of core#19739

Test Plan
ninja check-all