Differential D14537

[electrum] move delete_contacts to ContactList
ClosedPublic
Actions

Authored by PiRK on Sep 26 2023, 07:35.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa72a2c909229: [electrum] move delete_contacts to ContactList

Summary

Move another block of code that the MainWindow does not need to be in charge of.

Depends on D14536

Test Plan

In the Contacts tab, add, rename and delete a contact.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 26 2023, 07:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2023, 07:35

PiRK requested review of this revision.Sep 26 2023, 07:35

Harbormaster completed remote builds in B25162: Diff 42385.Sep 26 2023, 07:36

PiRK added a child revision: D14538: [electrum] move get*Filename wrappers out of MainWindow.Sep 26 2023, 07:41

Fabien accepted this revision.Sep 26 2023, 14:17

This revision is now accepted and ready to land.Sep 26 2023, 14:17

Closed by commit rABCa72a2c909229: [electrum] move delete_contacts to ContactList (authored by PiRK). · Explain WhySep 26 2023, 15:44

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCa72a2c909229: [electrum] move delete_contacts to ContactList.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc_gui/

qt/

contact_list.py

40 lines

main_window.py

40 lines

Diff 42399

View Options

electrum/electrumabc_gui/qt/contact_list.py