Paths

Table of Contentst

Differential D14541

[lint] exclude icons.py from more linters
ClosedPublic
Actions

Authored by PiRK on Sep 26 2023, 08:49.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC03c99fe4cc4a: [lint] exclude icons.py from more linters

Summary

This file is generated semi-automatically by running contrib/gen-icons.sh. After updating it with a new icon, I got flake8 errors related to the number of blank lines between blocks of code.
The number of blank lines arount the imports can trigger ISort.

Depends on D14540

Test Plan

Add extra blank lines and other formatting changes to icons.py and check that linters no longer care.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 26 2023, 08:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2023, 08:49

PiRK requested review of this revision.Sep 26 2023, 08:49

Harbormaster completed remote builds in B25166: Diff 42389.Sep 26 2023, 08:50

PiRK added a child revision: D14542: [electrum] add a new type of contact for ecash aliases.Sep 26 2023, 08:52

Fabien accepted this revision.Sep 26 2023, 14:23

This revision is now accepted and ready to land.Sep 26 2023, 14:23

Closed by commit rABC03c99fe4cc4a: [lint] exclude icons.py from more linters (authored by PiRK). · Explain WhySep 26 2023, 15:44

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC03c99fe4cc4a: [lint] exclude icons.py from more linters.

Revision Contents
Changeset List

Path

Size

2 lines

Diff 42403

.arclint

Loading...