Differential D14542

[electrum] add a new type of contact for ecash aliases
ClosedPublic
Actions

Authored by PiRK on Sep 26 2023, 08:52.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCd3cab7ae6e46: [electrum] add a new type of contact for ecash aliases

Summary

Note that this change will make wallet files containing the new type of contact incompatible with previous versions of Electrum ABC, because of the assertions that are now removed.
Depends on D14541

Test Plan

Apply this patch

diff --git a/electrum/electrumabc_gui/qt/contact_list.py b/electrum/electrumabc_gui/qt/contact_list.py
index cdbd40d13a..a625b9cc3f 100644
--- a/electrum/electrumabc_gui/qt/contact_list.py
+++ b/electrum/electrumabc_gui/qt/contact_list.py
@@ -395,7 +395,7 @@ class ContactList(PrintError, MessageBoxMixin, MyTreeWidget):
             prefix = networks.net.CASHADDR_PREFIX.lower() + ":"
             if address.lower().startswith(prefix):
                 address = address[len(prefix) :]
-            self.set_contact(d.get_name(), address)
+            self.set_contact(d.get_name(), address, typ="ecash")

     def set_contact(
         self, label, address, typ="address", replace: Optional[Contact] = None

Add a new contact, check that it shows with the eCash logo and correct type in the Contacts tab.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 26 2023, 08:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2023, 08:52

PiRK requested review of this revision.Sep 26 2023, 08:52

Harbormaster completed remote builds in B25167: Diff 42390.Sep 26 2023, 08:53

undo debugging patch

Harbormaster completed remote builds in B25168: Diff 42391.Sep 26 2023, 09:01

This does not add support for aliases, only add the type which is unused ?

In D14542#326630, @Fabien wrote:

This does not add support for aliases, only add the type which is unused ?

Correct. I'm working on the actual support in D14544

PiRK added a child revision: D14544: [electrum] implement adding eCash alias to contacts.Sep 26 2023, 14:44

Fabien accepted this revision.Sep 26 2023, 14:45

This revision is now accepted and ready to land.Sep 26 2023, 14:45

Closed by commit rABCd3cab7ae6e46: [electrum] add a new type of contact for ecash aliases (authored by PiRK). · Explain WhySep 26 2023, 15:44

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd3cab7ae6e46: [electrum] add a new type of contact for ecash aliases.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

2 lines

electrumabc_gui/

qt/

contact_list.py

4 lines

30207 lines

1 line

1 line

icons/

1 line

Diff 42404

electrum/electrumabc/contacts.py

Loading...

electrum/electrumabc_gui/qt/contact_list.py

Loading...

electrum/electrumabc_gui/qt/icons.py

Loading...

electrum/electrumabc_gui/qt/main_window.py

Loading...

electrum/icons.qrc

Loading...

electrum/icons/ecash-logo.svg

Loading...