Differential D14569

[electrum] use bytes for pubkey in keypairs arg for tx.sign()
ClosedPublic
Actions

Authored by PiRK on Oct 2 2023, 11:38.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC1c5159fd0fe1: [electrum] use bytes for pubkey in keypairs arg for tx.sign()

Summary

Depends on D14568

Test Plan

python test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25223
Build 50034: Build Diff	electrum-tests
Build 50033: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 2 2023, 11:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2023, 11:38

PiRK requested review of this revision.Oct 2 2023, 11:38

Harbormaster completed remote builds in B25223: Diff 42476.Oct 2 2023, 11:40

PiRK added a child revision: D14570: [electrum] avoid unneccessary bytes <-> hex conversion for block header.Oct 2 2023, 11:41

bytesofman accepted this revision.Oct 2 2023, 14:00

This revision is now accepted and ready to land.Oct 2 2023, 14:00

Closed by commit rABC1c5159fd0fe1: [electrum] use bytes for pubkey in keypairs arg for tx.sign() (authored by PiRK). · Explain WhyOct 2 2023, 15:33

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1c5159fd0fe1: [electrum] use bytes for pubkey in keypairs arg for tx.sign().

PiRK mentioned this in D14592: [electrum] fix get_tx_derivations for regular keystores and imported keys keystores.Oct 4 2023, 08:56

PiRK mentioned this in rABCdde0959297be: [electrum] fix get_tx_derivations for regular keystores and imported keys….Oct 4 2023, 11:36

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

commands.py

6 lines

tests/

test_wallet.py

2 lines

transaction.py

4 lines

wallet.py

8 lines

electrumabc_gui/

qt/

main_window.py

4 lines

Diff 42476

View Options

electrum/electrumabc/commands.py

View Options

electrum/electrumabc/tests/test_wallet.py

View Options

electrum/electrumabc/transaction.py

View Options

electrum/electrumabc/wallet.py

View Options

electrum/electrumabc_gui/qt/main_window.py

[electrum] use bytes for pubkey in keypairs arg for tx.sign()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42476

electrum/electrumabc/commands.py

electrum/electrumabc/tests/test_wallet.py

electrum/electrumabc/transaction.py

electrum/electrumabc/wallet.py

electrum/electrumabc_gui/qt/main_window.py

[electrum] use bytes for pubkey in keypairs arg for tx.sign()
ClosedPublic
Actions

Revision Contents
Changeset List