Paths

Table of Contentst

Differential D14749

[net] Return CService from GetLocalAddrForPeer and GetLocalAddress
ClosedPublic
Actions

Authored by PiRK on Nov 7 2023, 12:33.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC105ec9bd23db: [net] Return CService from GetLocalAddrForPeer and GetLocalAddress

Summary

This is a partial backport of core#25514
https://github.com/bitcoin/bitcoin/pull/25514/commits/5961f8eea1ad5be1a4bf8da63651e197a20359b2

Depends on D14748

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25554
Build 50689: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 50688: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 7 2023, 12:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 7 2023, 12:33

PiRK requested review of this revision.Nov 7 2023, 12:33

teamcity edited the summary of this revision. (Show Details)Nov 7 2023, 12:34

PiRK added a child revision: D14750: [net processing] Remove CNode::nLocalServices.Nov 7 2023, 12:44

Harbormaster completed remote builds in B25554: Diff 42978.Nov 7 2023, 13:01

Fabien accepted this revision.Nov 8 2023, 09:49

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/net.cpp
216

This revision is now accepted and ready to land.Nov 8 2023, 09:49

rebase and comment nit

Harbormaster completed remote builds in B25566: Diff 42992.Nov 8 2023, 11:01

Closed by commit rABC105ec9bd23db: [net] Return CService from GetLocalAddrForPeer and GetLocalAddress (authored by dergoegge <n.goeggi@gmail.com>, committed by PiRK). · Explain WhyNov 8 2023, 15:10

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC105ec9bd23db: [net] Return CService from GetLocalAddrForPeer and GetLocalAddress.

Revision Contents
Changeset List

Path

Size

src/

net.h

7 lines

net.cpp

29 lines

net_processing.cpp

10 lines

test/

net_tests.cpp

8 lines

Diff 42978

View Options

src/net.h

View Options

src/net.cpp

View Options

src/net_processing.cpp

View Options

[net] Return CService from GetLocalAddrForPeer and GetLocalAddressClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42978

src/net.h

src/net.cpp

src/net_processing.cpp

src/test/net_tests.cpp

[net] Return CService from GetLocalAddrForPeer and GetLocalAddress
ClosedPublic
Actions

Revision Contents
Changeset List