Rationalize parameters orders for UpdateCoins
ClosedPublic
Actions

Authored by deadalnix on Jun 5 2018, 23:13.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING340505daa73f: Rationalize parameters orders for UpdateCoins
rABC340505daa73f: Rationalize parameters orders for UpdateCoins

Summary

That way it is consistent with AddCoins.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

updatecoinorder

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2703
Build 3518: Bitcoin ABC Buildbot (legacy)
Build 3517: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 5 2018, 23:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2018, 23:13

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1479: Separate adding and spending coins for a given transaction..Jun 5 2018, 23:39

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2703: Diff 4066.Jun 5 2018, 23:49

jasonbcox accepted this revision.Jun 6 2018, 15:59

This revision is now accepted and ready to land.Jun 6 2018, 15:59

Closed by commit rABC340505daa73f: Rationalize parameters orders for UpdateCoins (authored by deadalnix). · Explain WhyJun 6 2018, 16:58

This revision was automatically updated to reflect the committed changes.

markblundeberg mentioned this in D3365: Merge #8498: Near-Bugfix: Optimization: Minimize the number of times it is checked that no money....Jun 19 2019, 03:20

Revision Contents
Changeset List

Path

Size

src/

test/

2 lines

4 lines

4 lines

6 lines

20 lines

Diff 4066

View Options

src/test/coins_tests.cpp

View Options

src/test/undo_tests.cpp

View Options

src/txmempool.cpp

View Options

src/validation.h

View Options

Rationalize parameters orders for UpdateCoinsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4066

src/test/coins_tests.cpp

src/test/undo_tests.cpp

src/txmempool.cpp

src/validation.h

src/validation.cpp

Rationalize parameters orders for UpdateCoins
ClosedPublic
Actions

Revision Contents
Changeset List