Differential D14892

propagate negative thread safety annotations for avalanche code
ClosedPublic
Actions

Authored by PiRK on Dec 1 2023, 13:13.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCb116942ecd84: propagate negative thread safety annotations for avalanche code

Summary

These annotations are all required for enabling negative lock assertions (D14894)

Depends on D14891

Test Plan

After D14894:

cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
ninja all check-all`

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25792
Build 51164: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 51163: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 1 2023, 13:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2023, 13:13

PiRK added a child revision: D14893: sync.h: Add GlobalMutex type.Dec 1 2023, 13:14

PiRK edited the test plan for this revision. (Show Details)Dec 1 2023, 13:19

PiRK published this revision for review.Dec 1 2023, 13:21

PiRK edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B25792: Diff 43347.Dec 1 2023, 13:37

Fabien accepted this revision.Dec 1 2023, 20:07

This revision is now accepted and ready to land.Dec 1 2023, 20:07

Closed by commit rABCb116942ecd84: propagate negative thread safety annotations for avalanche code (authored by PiRK). · Explain WhyDec 4 2023, 06:56

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCb116942ecd84: propagate negative thread safety annotations for avalanche code.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.h

70 lines

eventloop.h

6 lines

net_processing.cpp

14 lines

test/

net_tests.cpp

6 lines

validation.h

41 lines

Diff 43347

View Options

src/avalanche/processor.h

View Options

src/eventloop.h

View Options

src/net_processing.cpp

View Options

src/test/net_tests.cpp

View Options

propagate negative thread safety annotations for avalanche codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43347

src/avalanche/processor.h

src/eventloop.h

src/net_processing.cpp

src/test/net_tests.cpp

src/validation.h

propagate negative thread safety annotations for avalanche code
ClosedPublic
Actions

Revision Contents
Changeset List