There is no reason the make it synchronous. Also avoid holding a lock when calling the callback for good measure.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABC7154ba1d5668: [avalanche] Make the BlockFinalized validation callback asynchronous
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- block_finalized_scheduler
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 26450 Build 52470: Build Diff lint-circular-dependencies · build-diff · build-debug · build-without-wallet · build-clang-tidy · build-clang Build 52469: arc lint + arc unit
Event Timeline
| src/validation.cpp | ||
|---|---|---|
| 3706 | what do these brackets do? | |
| src/validation.cpp | ||
|---|---|---|
| 3706 | It's C++'s way of defining a scope, basically before the LOCK would go all the way to the return true (and including the BlockFinalized call) and would then be released, but with the scope it only goes to the closing }. | |