Add support for both way comparison for uint256/uint160
ClosedPublic
Actions

Authored by deadalnix on Jul 1 2018, 00:46.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGc4327aee8751: Add support for both way comparison for uint256/uint160
rABCc4327aee8751: Add support for both way comparison for uint256/uint160

Summary

Right now, they only compare one way, which is inconvenient.

Test Plan

Added test cases to cover the new function.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

uint256comp

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2778
Build 3666: Bitcoin ABC Buildbot (legacy)
Build 3665: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 1 2018, 00:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2018, 00:46

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2778: Diff 4172.Jul 1 2018, 01:21

Add variosu nits and a comment about endianess

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2779: Diff 4173.Jul 1 2018, 13:50

deadalnix added a child revision: D1527: Modify uint256's comparison to use proper endianess.Jul 1 2018, 19:13

schancel accepted this revision.Jul 2 2018, 15:23

This revision is now accepted and ready to land.Jul 2 2018, 15:23

Closed by commit rABCc4327aee8751: Add support for both way comparison for uint256/uint160 (authored by deadalnix). · Explain WhyJul 2 2018, 23:10

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

uint256_tests.cpp

39 lines

uint256.h

18 lines

Diff 4172

View Options

src/test/uint256_tests.cpp