Page MenuHomePhabricator
Differential D1567

Add test cases for CheckSignatureEncoding
ClosedPublic
Actions

Authored by deadalnix on Jul 15 2018, 13:26.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING6a75adc410a9: Add test cases for CheckSignatureEncoding
rABC6a75adc410a9: Add test cases for CheckSignatureEncoding
Summary

Mostly covering the SigHashType handling so far. More tests required, but it's better than nothing.

Depends on D1566

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sigencodingtest2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2874
Build 3852: Bitcoin ABC Buildbot (legacy)
Build 3851: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 15 2018, 13:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2018, 13:26
teamcity added a subscriber: teamcity.Jul 15 2018, 13:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix edited the summary of this revision. (Show Details)Jul 15 2018, 13:52
deadalnix added a parent revision: D1566: Add test for CheckPubKeyEncoding.
teamcity added a comment.Jul 15 2018, 14:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2874: Diff 4309.Jul 15 2018, 14:04
deadalnix updated this revision to Diff 4313.Jul 15 2018, 22:48

Various simple refactoring

teamcity added a comment.Jul 15 2018, 22:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1570: Add test for CheckSignatureEncoding to verify low S is checked properly..Jul 15 2018, 22:55
Harbormaster completed remote builds in B2877: Diff 4313.Jul 15 2018, 23:27
teamcity added a comment.Jul 15 2018, 23:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Jul 16 2018, 21:07
This revision is now accepted and ready to land.Jul 16 2018, 21:07
Closed by commit rABC6a75adc410a9: Add test cases for CheckSignatureEncoding (authored by deadalnix). · Explain WhyJul 17 2018, 16:00
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
script/
2 lines
test/
74 lines

Diff 4309

View Options

src/script/sigencoding.cpp

Loading...
View Options

src/test/sigencoding_tests.cpp

Loading...