Ignore sighash when checking for DER encoding.
ClosedPublic
Actions

Authored by deadalnix on Jul 17 2018, 15:59.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING49c721931424: Ignore sighash when checking for DER encoding.
rABC49c721931424: Ignore sighash when checking for DER encoding.

Summary

This updates the IsValidSignatureEncoding such as it checks the signature without the sighashtype.

Depends on D1576 and D1572

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

skipsighashtypeder

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2891
Build 3886: Bitcoin ABC Buildbot (legacy)
Build 3885: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 17 2018, 15:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 17 2018, 15:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2891: Diff 4335.Jul 17 2018, 17:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D1578: Refactor signature encoding checks to separates checks of the SigHashType and other checks.Jul 18 2018, 01:05

jasonbcox accepted this revision.Jul 20 2018, 05:23

This revision is now accepted and ready to land.Jul 20 2018, 05:23

rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2920: Diff 4373.Jul 23 2018, 13:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC49c721931424: Ignore sighash when checking for DER encoding. (authored by deadalnix). · Explain WhyJul 23 2018, 17:27

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

script/

sigencoding.cpp

20 lines

Diff 4335

View Options

src/script/sigencoding.cpp

Ignore sighash when checking for DER encoding.ClosedPublicActions