Add CheckDataSignatureEncoding to check signature with a sighashtype.
ClosedPublic
Actions

Authored by deadalnix on Jul 18 2018, 14:48.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING89985a3295b6: Add CheckDataSignatureEncoding to check signature with a sighashtype.
rABC89985a3295b6: Add CheckDataSignatureEncoding to check signature with a sighashtype.

Summary

As per title.

Depends on D1578

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

checkdatasigencoding

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2898
Build 3900: Bitcoin ABC Buildbot (legacy)
Build 3899: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 18 2018, 14:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 18 2018, 14:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix edited the summary of this revision. (Show Details)Jul 18 2018, 14:49

deadalnix added a parent revision: D1578: Refactor signature encoding checks to separates checks of the SigHashType and other checks.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2898: Diff 4348!Jul 18 2018, 15:48

deadalnix added a child revision: D1580: Make sigencoding_tests significantly faster by not checking the full sigashtype/flags combinatorial.Jul 18 2018, 16:06

jasonbcox accepted this revision.Jul 23 2018, 15:40

This revision is now accepted and ready to land.Jul 23 2018, 15:40

Closed by commit rABC89985a3295b6: Add CheckDataSignatureEncoding to check signature with a sighashtype. (authored by deadalnix). · Explain WhyJul 23 2018, 17:29

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

script/

sigencoding.h

8 lines

sigencoding.cpp

12 lines

test/

sigencoding_tests.cpp

11 lines

Diff 4348

View Options

src/script/sigencoding.h

View Options

src/script/sigencoding.cpp

View Options

src/test/sigencoding_tests.cpp

Add CheckDataSignatureEncoding to check signature with a sighashtype.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4348

src/script/sigencoding.h

src/script/sigencoding.cpp

src/test/sigencoding_tests.cpp

Add CheckDataSignatureEncoding to check signature with a sighashtype.
ClosedPublic
Actions

Revision Contents
Changeset List