Paths

Table of Contentst

Differential D15808

get config via chainstatemanager when possible (5/5)
ClosedPublic
Actions

Authored by PiRK on Mar 29 2024, 08:23.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC424d0fc3f6c1: get config via chainstatemanager when possible (5/5)

Summary

Access the config via the chainman's m_options member in LoadExternalBlockFile, VerifyDB, AcceptBlock

After this commit, the only validation functions that still need to be passed a config argument are in ATMPArgs and BlockValidationOptions

Depends on D15807

Test Plan

With chronik
ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 29 2024, 08:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 29 2024, 08:23

PiRK requested review of this revision.Mar 29 2024, 08:23

@bot build-chronik

teamcity awarded a token.Mar 29 2024, 08:37

Harbormaster completed remote builds in B28150: Diff 46580.Mar 29 2024, 08:40

PiRK added a child revision: D15809: refactor: use chainman instead of chainParams for DeploymentActive*.Mar 29 2024, 08:45

Fabien accepted this revision.Mar 29 2024, 15:32

This revision is now accepted and ready to land.Mar 29 2024, 15:32

Closed by commit rABC424d0fc3f6c1: get config via chainstatemanager when possible (5/5) (authored by PiRK). · Explain WhyMar 30 2024, 17:23

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC424d0fc3f6c1: get config via chainstatemanager when possible (5/5).

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

processor_tests.cpp

3 lines

init.cpp

6 lines

node/

blockstorage.h

2 lines

blockstorage.cpp

10 lines

chainstate.cpp

6 lines

rpc/

blockchain.cpp

2 lines

test/

coinstatsindex_tests.cpp

4 lines

fuzz/

load_external_block_file.cpp

5 lines

validation_chainstate_tests.cpp

4 lines

validation_tests.cpp

9 lines

validation.h

19 lines

validation.cpp

25 lines

Diff 46638

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/init.cpp

View Options

src/node/blockstorage.h

View Options

src/node/blockstorage.cpp

View Options

src/node/chainstate.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/test/coinstatsindex_tests.cpp

View Options

src/test/fuzz/load_external_block_file.cpp

View Options

src/test/validation_chainstate_tests.cpp

View Options

src/test/validation_tests.cpp

View Options

src/validation.h

View Options

get config via chainstatemanager when possible (5/5)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46638

src/avalanche/test/processor_tests.cpp

src/init.cpp

src/node/blockstorage.h

src/node/blockstorage.cpp

src/node/chainstate.cpp

src/rpc/blockchain.cpp

src/test/coinstatsindex_tests.cpp

src/test/fuzz/load_external_block_file.cpp

src/test/validation_chainstate_tests.cpp

src/test/validation_tests.cpp

src/validation.h

src/validation.cpp

get config via chainstatemanager when possible (5/5)
ClosedPublic
Actions

Revision Contents
Changeset List