Page MenuHomePhabricator
Differential D15813

Move ::nMinimumChainWork into ChainstateManager
ClosedPublic
Actions

Authored by PiRK on Mar 29 2024, 14:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3ece82b609c1: Move ::nMinimumChainWork into ChainstateManager
Summary

This changes the minimum chain work for the bitcoin-chainstate
executable. Previously it was uint256{}, now it is the chain's default
minimum chain work
.
This is a partial backport of core#25704 and core#26409
https://github.com/bitcoin/bitcoin/pull/25704/commits/cccca83099453bf0882bce4f897f77eee5836e8b
https://github.com/bitcoin/bitcoin/pull/26409/commits/fa29ef00adac6f0842acdd38344820a1ce0e3087

Depends on D15812

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 29 2024, 14:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 29 2024, 14:52
PiRK requested review of this revision.Mar 29 2024, 14:52
teamcity edited the summary of this revision. (Show Details)Mar 29 2024, 14:52
PiRK added a child revision: D15814: Move ::fCheckpointsEnabled into ChainstateManager.Mar 29 2024, 14:54
Harbormaster completed remote builds in B28168: Diff 46600.Mar 29 2024, 15:27
Fabien accepted this revision.Mar 29 2024, 16:38
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/init.cpp
2394 ↗(On Diff #46600)

This is incredibly counter intuitive

This revision is now accepted and ready to land.Mar 29 2024, 16:38
PiRK added inline comments.Mar 30 2024, 09:22
src/init.cpp
2394 ↗(On Diff #46600)

Maybe I should change it to

Assert(!ApplyArgsManOptions(args, chainman_opts).has_value());

Still not great, but at least it explicitly shows that it is not a simple boolean.

Closed by commit rABC3ece82b609c1: Move ::nMinimumChainWork into ChainstateManager (authored by MacroFake <falke.marco@gmail.com>, committed by PiRK). · Explain WhyMar 30 2024, 17:23
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC3ece82b609c1: Move ::nMinimumChainWork into ChainstateManager.

Revision Contents
Changeset List

Diff 46642

View Options

src/init.cpp

Loading...
View Options

src/kernel/chainstatemanager_opts.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/node/chainstate.cpp

Loading...
View Options

src/node/chainstatemanager_args.h

Loading...
View Options

src/node/chainstatemanager_args.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...