Paths

Table of Contentst

Differential D15814

Move ::fCheckpointsEnabled into ChainstateManager
ClosedPublic
Actions

Authored by PiRK on Fri, Mar 29, 14:54.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC7538f22924c4: Move ::fCheckpointsEnabled into ChainstateManager

Summary

This is a partial backport of core#25704
https://github.com/bitcoin/bitcoin/pull/25704/commits/fa43188d86288fa6666307a77c106c8f069ebdbe

Note that additional changes in setup_common.cpp and miner_tests.cpp were required to make miner_tests pass with checkpoints disabled.
Depends on D15813

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Fri, Mar 29, 14:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Mar 29, 14:54

PiRK requested review of this revision.Fri, Mar 29, 14:54

teamcity edited the summary of this revision. (Show Details)Fri, Mar 29, 14:54

PiRK added a child revision: D15815: Move ::fCheckBlockIndex into ChainstateManager.Fri, Mar 29, 14:56

Harbormaster completed remote builds in B28169: Diff 46601.Fri, Mar 29, 15:36

Fabien accepted this revision.Fri, Mar 29, 16:40

This revision is now accepted and ready to land.Fri, Mar 29, 16:40

Closed by commit rABC7538f22924c4: Move ::fCheckpointsEnabled into ChainstateManager (authored by MacroFake <falke.marco@gmail.com>, committed by PiRK). · Explain WhySat, Mar 30, 17:23

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7538f22924c4: Move ::fCheckpointsEnabled into ChainstateManager.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

13 lines

kernel/

chainstatemanager_opts.h

2 lines

node/

chainstatemanager_args.cpp

4 lines

test/

miner_tests.cpp

15 lines

util/

setup_common.cpp

4 lines

validation.h

2 lines

validation.cpp

3 lines

Diff 46643

View Options

src/init.cpp

View Options

src/kernel/chainstatemanager_opts.h

View Options

src/node/chainstatemanager_args.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/util/setup_common.cpp

View Options

src/validation.h

View Options

Move ::fCheckpointsEnabled into ChainstateManagerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46643

src/init.cpp

src/kernel/chainstatemanager_opts.h

src/node/chainstatemanager_args.cpp

src/test/miner_tests.cpp

src/test/util/setup_common.cpp

src/validation.h

src/validation.cpp

Move ::fCheckpointsEnabled into ChainstateManager
ClosedPublic
Actions

Revision Contents
Changeset List